nipy / PySurfer

Cortical neuroimaging visualization in Python

https://pysurfer.github.io/

BSD 3-Clause "New" or "Revised" License

239 stars 98 forks source link

FIX: Fix set surf #232

Closed larsoner closed 6 years ago

larsoner commented 6 years ago

@christianbrodbeck can you confirm this fixes the bug you pointed out in https://github.com/mne-tools/mne-python/pull/5012 ?

christianbrodbeck commented 6 years ago

Yes this fixes it. But it's not necessary for older versions. Must be that the dev version of mayavi makes a copy where the earlier version used a view (hence in-place update of the array in load_geometry()).

larsoner commented 6 years ago

Ahh -- it would actually make sense for them to do this, it should be faster to only upload things that are known to have changed on update, which you can't for in-place array changes. It might have been luck that it worked before. That is my suspicion anyway based on my limitied graphics optimization knowledge. But feel free to open a Mayavi bug if you're curious.

codecov-io commented 6 years ago

Codecov Report

Merging #232 into master will increase coverage by 0.01%. The diff coverage is 100%.

@@            Coverage Diff            @@
##           master    #232      +/-   ##
=========================================
+ Coverage   74.29%   74.3%   +0.01%     
=========================================
  Files           7       7              
  Lines        2439    2440       +1     
  Branches      487     487              
=========================================
+ Hits         1812    1813       +1     
  Misses        454     454              
  Partials      173     173

christianbrodbeck commented 6 years ago

Yeah that's plausible that that's behind the change. Glad you caught it so quickly!