search

nipy / PySurfer

Cortical neuroimaging visualization in Python
https://pysurfer.github.io/
BSD 3-Clause "New" or "Revised" License
239 stars 98 forks source link

MRG: Add units kwarg #238

Closed larsoner closed 6 years ago

larsoner commented 6 years ago

This PR:

  1. Adds units kwarg for mm or m with tests and modified examples to show it works
  2. Fixes bug where distance wasn't always respected in show_view (because there are two ways to supply it)
  3. Removes Surface.save_geometry because 1) it's unlikely that it was used in production code by users, 2) it's not used in PySurfer at all (not even in tests) and 3) it's really duplicating nibabel functionality without adding much.
  4. Removes two parameters that have been deprecated for 3 years.

Closes #219.

larsoner commented 6 years ago

Updated examples: foci, meg, vector meg

larsoner commented 6 years ago

I have no idea why Travis was deactivated in the nipy org (?), but I just reactivated it and will force push so it runs.

larsoner commented 6 years ago

Anybody have time to look? If not I'll go ahead and merge tomorrow.