nipy / PySurfer

Cortical neuroimaging visualization in Python

https://pysurfer.github.io/

BSD 3-Clause "New" or "Revised" License

239 stars 98 forks source link

FIX: AppVeyor #244

Closed larsoner closed 6 years ago

mwaskom commented 6 years ago

codecov-io commented 6 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@65a22bf). Click here to learn what that means. The diff coverage is 100%.

@@            Coverage Diff            @@
##             master     #244   +/-   ##
=========================================
  Coverage          ?   74.98%           
=========================================
  Files             ?        7           
  Lines             ?     2479           
  Branches          ?      494           
=========================================
  Hits              ?     1859           
  Misses            ?      447           
  Partials          ?      173

larsoner commented 6 years ago

AppVeyor actually works but I broke Travis by trying to simultaneously eradicate nose :)

But this last commit should do it!

mwaskom commented 6 years ago

Either way I lolled pretty hard when I opened this issue and saw the commit history. Once it's running maybe you'll want to rebase the pain away :)

larsoner commented 6 years ago

... I already had to rebase once due to merge conflict :)

But yes the "squash and merge" button is very satisfying in these situations. And the situation is actually worse than it looks, as I force-pushed a few along the way after tweaking them with commit --amend!

mwaskom commented 6 years ago

BTW is nose bit rot actually breaking things or did you just want to be preemptive about jettisoning it? I'm not looking forward to having to rip it out of other projects.

larsoner commented 6 years ago

I mostly wanted to see how difficult it would be. Turns out it was more annoying than I thought. Lots of little gotchas in there.