nipy / PySurfer

Cortical neuroimaging visualization in Python

https://pysurfer.github.io/

BSD 3-Clause "New" or "Revised" License

239 stars 98 forks source link

MRG: Add auto offscreen mode #245

Closed larsoner closed 6 years ago

larsoner commented 6 years ago

Adds offscreen='auto' as the default, which will use the mlab.options.offscreen value.

codecov-io commented 6 years ago

Codecov Report

Merging #245 into master will increase coverage by 0.03%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #245      +/-   ##
==========================================
+ Coverage   74.93%   74.96%   +0.03%     
==========================================
  Files           7        7              
  Lines        2474     2477       +3     
  Branches      493      494       +1     
==========================================
+ Hits         1854     1857       +3     
  Misses        447      447              
  Partials      173      173

larsoner commented 6 years ago

https://161-1551431-gh.circle-artifacts.com/0/html/generated/surfer.Brain.html

agramfort commented 6 years ago

what is it useful for?

larsoner commented 6 years ago

For creating screenshots it's safer (sometimes on Linux you get junk images/screenshots in Mayavi with actual windows). With this I can do mlab.options.offscreen = True then stc.plot(...) without needing to add the explicit offscreen option to stc.plot.

larsoner commented 6 years ago

(Arguably also we should have always respected the mlab.options value rather than defaulting to offscreen=False)

agramfort commented 6 years ago

ok no objection to merge on my end