nipy / PySurfer

Cortical neuroimaging visualization in Python
https://pysurfer.github.io/
BSD 3-Clause "New" or "Revised" License
243 stars 97 forks source link

[MRG] ADD: Brain.remove_foci() #251

Closed christianbrodbeck closed 6 years ago

christianbrodbeck commented 6 years ago

Seemed like it was missing and simple enough to add.

mwaskom commented 6 years ago

Do we use this style of api for any of the other kinds of features that can be added?

christianbrodbeck commented 6 years ago

Yes, remove_data() and remove_labels(), glad you asked :)

christianbrodbeck commented 6 years ago

We could add a new Brain attribute to keep track of unnamed foci too, but it would add some more overhead...

codecov-io commented 6 years ago

Codecov Report

Merging #251 into master will increase coverage by 0.13%. The diff coverage is 100%.

@@            Coverage Diff            @@
##           master    #251      +/-   ##
=========================================
+ Coverage   74.96%   75.1%   +0.13%     
=========================================
  Files           7       7              
  Lines        2477    2494      +17     
  Branches      494     500       +6     
=========================================
+ Hits         1857    1873      +16     
- Misses        447     448       +1     
  Partials      173     173
larsoner commented 6 years ago

Thanks @christianbrodbeck