nipy / PySurfer

Cortical neuroimaging visualization in Python

https://pysurfer.github.io/

BSD 3-Clause "New" or "Revised" License

239 stars 98 forks source link

MRG: Fix scale_data_colormap and add FXAA #261

Closed larsoner closed 5 years ago

larsoner commented 5 years ago

Closes #260.

@hichamjanati can you see if this solves your problem?

I also added a use_fxaa = True to improve rendering quality slightly while I was in there, and fixed where we should have enabled backface culling for the quiver arrows.

hichamjanati commented 5 years ago

Thanks @larsoner, it seems to be fixed now.

agramfort commented 5 years ago

thx @larsoner

but I have no clue why CIs fail

larsoner commented 5 years ago

Because the testing mayavi backend is incomplete, should be a quick fix

codecov-io commented 5 years ago

Codecov Report

Merging #261 into master will increase coverage by 0.04%. The diff coverage is 83.33%.

@@            Coverage Diff             @@
##           master     #261      +/-   ##
==========================================
+ Coverage    74.9%   74.95%   +0.04%     
==========================================
  Files           7        7              
  Lines        2506     2511       +5     
  Branches      501      505       +4     
==========================================
+ Hits         1877     1882       +5     
  Misses        454      454              
  Partials      175      175

larsoner commented 5 years ago

I'll merge since it looks like a +2