nipy / PySurfer

Cortical neuroimaging visualization in Python

https://pysurfer.github.io/

BSD 3-Clause "New" or "Revised" License

239 stars 98 forks source link

MRG: width/height in offscreen mode #265

Closed larsoner closed 5 years ago

larsoner commented 5 years ago

Fixes a bug from #245 that showed up when w != h as values ended up swapped.

codecov-io commented 5 years ago

Codecov Report

Merging #265 into master will increase coverage by 0.05%. The diff coverage is 100%.

@@           Coverage Diff            @@
##           master   #265      +/-   ##
========================================
+ Coverage   74.95%    75%   +0.05%     
========================================
  Files           7      7              
  Lines        2511   2517       +6     
  Branches      505    506       +1     
========================================
+ Hits         1882   1888       +6     
  Misses        454    454              
  Partials      175    175

larsoner commented 5 years ago

Ready for review/merge from my end. This one is a pretty trivial fix aside from the necessary CI updating. I'll merge tomorrow probably assuming it comes back green unless someone wants more time to look.

agramfort commented 5 years ago

thx @larsoner