add_overlay colors the whole brain when given all zeros

nipy / PySurfer

Cortical neuroimaging visualization in Python

https://pysurfer.github.io/

BSD 3-Clause "New" or "Revised" License

239 stars 98 forks source link

add_overlay colors the whole brain when given all zeros #267

Closed alexrockhill closed 4 years ago

alexrockhill commented 5 years ago

I'm not sure if this is the intended behavior but it was quite confusing to me why the whole brain was colored.

Minimally reproducible example:

brain = Brain('fsaverage', 'lh', 'inflated', subjects_dir=fs_dir) brain.add_overlay(np.zeros((1000000)), min=0.04, max=2.5, sign="pos")

larsoner commented 4 years ago

add_overlay seems to have far fewer capabilities than add_data, which is probably what you want to use. Maybe we should make a note saying that add_data should be preferred nowadays, unless there is something add_overlay does that add_data does not.