nipy / PySurfer

Cortical neuroimaging visualization in Python

https://pysurfer.github.io/

BSD 3-Clause "New" or "Revised" License

239 stars 98 forks source link

BUG: Properly clean up on del #279

Closed larsoner closed 4 years ago

larsoner commented 4 years ago

This should fix a bug @drammock hit where memory consumption crept up with multiple fig use and mlab.options.offscreen=True. Basically we should make sure we close the figures we create, since the offscreen ones can stay open and consume memory.

codecov[bot] commented 4 years ago

Codecov Report

Merging #279 into master will increase coverage by 0.13%. The diff coverage is 50%.

@@            Coverage Diff             @@
##           master     #279      +/-   ##
==========================================
+ Coverage   74.31%   74.45%   +0.13%     
==========================================
  Files           7        7              
  Lines        2570     2568       -2     
  Branches      514      513       -1     
==========================================
+ Hits         1910     1912       +2     
+ Misses        482      480       -2     
+ Partials      178      176       -2

mwaskom commented 4 years ago

This looks fine, but has @drammock confirmed that it works? I don’t see a linked issue.

drammock commented 4 years ago

Sorry. Yes, confirmed. I probably did so in slack or in a private repo and forgot to report back here.

mwaskom commented 4 years ago

Great, thanks @drammock