nipy / PySurfer

Cortical neuroimaging visualization in Python

https://pysurfer.github.io/

BSD 3-Clause "New" or "Revised" License

239 stars 98 forks source link

MRG, FIX: Fix bug with scale_data_colormap #287

Closed larsoner closed 4 years ago

larsoner commented 4 years ago

Closes #281

On master the snippet from #281 gives:

add_data_bug

And on this PR:

add_data_bug

@mwaskom feel free to look/test/merge if you're happy.

codecov[bot] commented 4 years ago

Codecov Report

Merging #287 into master will increase coverage by 0.33%. The diff coverage is 84.61%.

@@            Coverage Diff             @@
##           master     #287      +/-   ##
==========================================
+ Coverage    74.5%   74.83%   +0.33%     
==========================================
  Files           7        7              
  Lines        2577     2583       +6     
  Branches      513      513              
==========================================
+ Hits         1920     1933      +13     
+ Misses        480      475       -5     
+ Partials      177      175       -2

larsoner commented 4 years ago

Also @mwaskom I think this was listed as the only (?) blocker for release, so if you're okay with it once this is merged I'll push a new version out

mwaskom commented 4 years ago

I'm traveling for the next few days and won't have a chance to look closely but +1 on release and go ahead and merge if it resolves the issue.

larsoner commented 4 years ago

Okay, onward we go!