nipy / PySurfer

Cortical neuroimaging visualization in Python

https://pysurfer.github.io/

BSD 3-Clause "New" or "Revised" License

239 stars 98 forks source link

MRG, FIX: Remove force render #289

Closed larsoner closed 4 years ago

larsoner commented 4 years ago

Over at MNE we have been getting failures that seem to be triggered by the GUI stuff we do when __del__ is called. This hopefully avoids the problem.

WIP until we can do some runs in MNE to see if it makes the problem go away.

codecov[bot] commented 4 years ago

Codecov Report

Merging #289 into master will increase coverage by 7.19%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #289      +/-   ##
==========================================
+ Coverage   67.75%   74.94%   +7.19%     
==========================================
  Files           7        7              
  Lines        2583     2594      +11     
  Branches      513      514       +1     
==========================================
+ Hits         1750     1944     +194     
+ Misses        650      475     -175     
+ Partials      183      175       -8

larsoner commented 4 years ago

Added Azure as a CI while I was at it

larsoner commented 4 years ago

Same failures occur in MNE, but I still think this is worth having since the _force_render does not seem to be required here

larsoner commented 4 years ago

@mwaskom feel free to review/merge if you're happy

mwaskom commented 4 years ago

Thanks!