nipy / PySurfer

Cortical neuroimaging visualization in Python

https://pysurfer.github.io/

BSD 3-Clause "New" or "Revised" License

239 stars 98 forks source link

STY: Dont log info messages by default #293

Closed larsoner closed 4 years ago

larsoner commented 4 years ago

When processing things in a loop I get spammed by a lot of:

colormap sequential: [0.00e+00, 9.68e-01, 1.94e+00] (transparent)
colormap sequential: [0.00e+00, 9.68e-01, 1.94e+00] (transparent)
colormap sequential: [0.00e+00, 9.68e-01, 1.94e+00] (transparent)
colormap sequential: [0.00e+00, 9.68e-01, 1.94e+00] (transparent)

I don't think this is very useful for users in general, so by default we probably shouldn't log it.

larsoner commented 4 years ago

Argh this does not work, I'll probably just set them to logger.debug instead of logger.info

mwaskom commented 4 years ago

+100 on this; I have verbose=0 set all over the place.

codecov[bot] commented 4 years ago

Codecov Report

Merging #293 into master will decrease coverage by 0.03%. The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master     #293      +/-   ##
==========================================
- Coverage   74.94%   74.90%   -0.04%     
==========================================
  Files           7        7              
  Lines        2594     2594              
  Branches      514      514              
==========================================
- Hits         1944     1943       -1     
- Misses        475      476       +1     
  Partials      175      175

larsoner commented 4 years ago

Just changed all logger.info to logger.debug, then fixed an MNE install error