search

nipy / dmriprep

MOVED TO https://github.com/nipreps/dmriprep
Other
17 stars 11 forks source link

Preserve `dim_info` #35

Closed arokem closed 5 years ago

arokem commented 5 years ago

The output of dmriprep currently has: 

In [7]: hdr = img.header                                                        

In [8]: hdr.get_dim_info()                                                      
Out[8]: (None, None, None)

We want to set this to be consistent with the input. See #32

richford commented 5 years ago

I believe I can use header=img.header to inherit the old header info. However, I'll need to update the dim value to reflect that I've dropped some volumes, correct?

@arokem, are there any other fields that I should update.

richford commented 5 years ago

@arokem @akeshavan For that matter, we don't know for sure if the input is a Nifti1 image or a Nifti2 image. I should inspect the incoming image and use that type for the output as well, correct?

arokem commented 5 years ago

I've only rarely (if ever) seen a Nifti2 in the wild. I am not even entirely sure what the difference is.

On Fri, Dec 7, 2018 at 2:08 PM Adam Richie-Halford notifications@github.com wrote:

@arokem https://github.com/arokem @akeshavan https://github.com/akeshavan For that matter, we don't know for sure if the input is a Nifti1 image or a Nifti2 image. I should inspect the incoming image and use that type for the output as well, correct?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/nipy/dmriprep/issues/35#issuecomment-445381041, or mute the thread https://github.com/notifications/unsubscribe-auth/AAHPNnjPyb6EIjeAPbDwnMwlbzbf2Skyks5u2ubngaJpZM4ZJMRL .