Closed jwodder closed 1 year ago
Patch and project coverage have no change.
Comparison is base (
0c3f14b
) 81.57% compared to head (764e998
) 81.57%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
I already merged some PR and caused conflict.
I am with a workaround for now, but ideally that test_get_key_info_for_fmap_assignment
should be fixed - probably sample NIFTI file first copied to temp dir and then used in there. I missed the fact that we are modifying the tests directory - that makes heudiconv being untestable without write access to tests, which isn't good.
@yarikoptic Conflict resolved, and issue #665 created for updating the test.
:rocket: PR was released in v0.13.0
:rocket:
One of the tests creates a
sample_nifti.json
file in theheudiconv/tests/data/
directory, and this file needs to be in the same directory as some of the files that are already in thedata/
directory (and so creating it in a temp directory won't work). This PR thus adds the file to.gitignore
so that it will be ignored by Git.