codecov[bot]
commented
1 year ago Codecov Report
Patch coverage: 20.00% and project coverage change: -0.08 :warning:
Comparison is base (
83c8424) 82.00% compared to head (7904d46) 81.93%.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #695 +/- ## ========================================== - Coverage 82.00% 81.93% -0.08% ========================================== Files 41 41 Lines 4130 4135 +5 ========================================== + Hits 3387 3388 +1 - Misses 743 747 +4 ``` | [Impacted Files](https://app.codecov.io/gh/nipy/heudiconv/pull/695?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nipy) | Coverage Δ | | |---|---|---| | [heudiconv/convert.py](https://app.codecov.io/gh/nipy/heudiconv/pull/695?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nipy#diff-aGV1ZGljb252L2NvbnZlcnQucHk=) | `84.71% <20.00%> (-0.83%)` | :arrow_down: |:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
apparently we do not fail whenever dcm2niix fails. I think it might have been some change in behavior, may be in nipype?
apparently there is odd difference in nipype invocation of dcm2niix -- it doesn't fail whenever exits with 1: https://github.com/nipy/nipype/issues/3592 .
TODOs: