nipy / heudiconv

Flexible DICOM conversion into structured directory layouts
https://heudiconv.readthedocs.io
Other
235 stars 125 forks source link

Do not demand --files for all commands, even those which do not care about it (like populate-intended-for) #708

Closed yarikoptic closed 1 year ago

yarikoptic commented 1 year ago

It refactors how we do check and assertion now for mypy to stay quiet. Closes #707

codecov[bot] commented 1 year ago

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (a882f73) 82.00% compared to head (40f34b9) 81.95%. Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #708 +/- ## ========================================== - Coverage 82.00% 81.95% -0.06% ========================================== Files 41 41 Lines 4130 4139 +9 ========================================== + Hits 3387 3392 +5 - Misses 743 747 +4 ``` | [Files](https://app.codecov.io/gh/nipy/heudiconv/pull/708?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nipy) | Coverage Δ | | |---|---|---| | [heudiconv/main.py](https://app.codecov.io/gh/nipy/heudiconv/pull/708?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nipy#diff-aGV1ZGljb252L21haW4ucHk=) | `77.71% <54.54%> (-1.21%)` | :arrow_down: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 10 months ago

:rocket: PR was released in v1.0.1 :rocket: