search

nipy / heudiconv

Flexible DICOM conversion into structured directory layouts
https://heudiconv.readthedocs.io
Other
234 stars 125 forks source link

Convert assertion into a warning that we would not use dicom dir tempate option #709

Closed yarikoptic closed 11 months ago

yarikoptic commented 11 months ago

To avoid users confusion etc. Ref: https://github.com/nipy/heudiconv/issues/707#issuecomment-1738371656

codecov[bot] commented 11 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (aa4c785) 81.95% compared to head (330ed76) 81.93%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #709 +/- ## ========================================== - Coverage 81.95% 81.93% -0.02% ========================================== Files 41 41 Lines 4139 4140 +1 ========================================== Hits 3392 3392 - Misses 747 748 +1 ``` | [Files](https://app.codecov.io/gh/nipy/heudiconv/pull/709?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nipy) | Coverage Δ | | |---|---|---| | [heudiconv/main.py](https://app.codecov.io/gh/nipy/heudiconv/pull/709?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nipy#diff-aGV1ZGljb252L21haW4ucHk=) | `77.27% <50.00%> (-0.45%)` | :arrow_down: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 9 months ago

:rocket: PR was released in v1.0.1 :rocket: