Drop Python 3.7 support

yarikoptic commented 9 months ago

[x] Might need #721 merged first since resolves problem with deprecation warning on 3.11 which would be relevant here

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (e259f35) 81.97% compared to head (2e761a5) 81.97%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #722 +/- ## ======================================= Coverage 81.97% 81.97% ======================================= Files 41 41 Lines 4149 4149 ======================================= Hits 3401 3401 Misses 748 748 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

yarikoptic commented 9 months ago

@jwodder -- do you have quick clue on why we get older setuptools installed

2023-12-08T22:32:04.1539412Z   × pip subprocess to install build dependencies did not run successfully.
2023-12-08T22:32:04.1540645Z   │ exit code: 2
2023-12-08T22:32:04.1541435Z   ╰─> [110 lines of output]
2023-12-08T22:32:04.1542543Z       Ignoring numpy: markers 'python_version == "3.7"' don't match your environment
2023-12-08T22:32:04.1544530Z       Ignoring numpy: markers 'python_version >= "3.8" and python_version < "3.11"' don't match your environment
2023-12-08T22:32:04.1545934Z       Collecting setuptools==60.5
2023-12-08T22:32:04.1546922Z         Downloading setuptools-60.5.0-py3-none-any.whl (958 kB)
2023-12-08T22:32:04.1548651Z            ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 959.0/959.0 kB 26.6 MB/s eta 0:00:00

so that we get

        File "/tmp/pip-build-env-pb4b294m/overlay/lib/python3.12/site-packages/setuptools/__init__.py", line 10, in <module>
          import distutils.core
      ModuleNotFoundError: No module named 'distutils'

on py 3.12 ?

jwodder commented 9 months ago

@yarikoptic This is the fault of pylibjpeg-libjpeg. Its build requirements pin setuptools for some reason, but the actual build failure is due to the fact that these requirements specify exactly numpy 1.23.2 on Python 3.11 and above, and that version (which was released over a year ago) requires distutils to install.

yarikoptic commented 9 months ago

Thank you @jwodder for the analysis!!! my humble attempt https://github.com/pydicom/pylibjpeg-libjpeg/pull/48

yarikoptic commented 9 months ago

meanwhile I will just drop attempt at 3.12 here, so we will just end up dropping 3.7

github-actions[bot] commented 9 months ago

:rocket: PR was released in v1.0.1 :rocket:

nipy / heudiconv

Drop Python 3.7 support #722

Codecov Report