Closed bpinsard closed 6 months ago
Attention: 4 lines
in your changes are missing coverage. Please review.
Comparison is base (
1d614cd
) 81.97% compared to head (bc4ce42
) 82.00%. Report is 7 commits behind head on master.
Files | Patch % | Lines |
---|---|---|
heudiconv/convert.py | 75.00% | 4 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: PR was released in v1.0.2
:rocket:
GE Hyperband (at least some versions of it) multi-echo data get diffusion vector/values in the dicom tags used by dcm2niix to generate bvecs/bvals.
While heudiconv is properly coded to remove such data when there is a single bvec/bval per series, multi-echo data outputs as many as there are echoes causing it to crash.
The current PR fixes that by checking if all files only contain zeros bvals when not suffixed
_dwi
, and remove all of them appropriately.FYI @miltoncamachocamacho