search

nipy / heudiconv

Flexible DICOM conversion into structured directory layouts
https://heudiconv.readthedocs.io
Other
232 stars 125 forks source link

rebase, add basic test #731

Closed bpinsard closed 7 months ago

codecov[bot] commented 7 months ago

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (d798b12) 81.88% compared to head (fe9f918) 82.02%. Report is 10 commits behind head on enh-custom-seqinfo.

:exclamation: Current head fe9f918 differs from pull request most recent head 86e35c7. Consider uploading reports for the commit 86e35c7 to get more accurate results

Files Patch % Lines
heudiconv/main.py 53.84% 6 Missing :warning:
heudiconv/dicoms.py 76.47% 4 Missing :warning:
heudiconv/heuristics/example.py 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## enh-custom-seqinfo #731 +/- ## ====================================================== + Coverage 81.88% 82.02% +0.14% ====================================================== Files 41 41 Lines 4117 4178 +61 ====================================================== + Hits 3371 3427 +56 - Misses 746 751 +5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

yarikoptic commented 7 months ago

something went wrong with rebase I guess...

bpinsard commented 7 months ago

Yes, tried to rebase, if I open the PR to master it shows commits correctly, but not when opening to enh-custom-seqinfo. Maybe if nipy branch get rebased first it will fix the issue.

yarikoptic commented 7 months ago

I have rebased https://github.com/nipy/heudiconv/pull/581 now, invited you to join our heudiconv team so you could push directly into that PR (just never push to master please ;) )

bpinsard commented 7 months ago

Great, should we add a branch protection rule for master?