Closed octomike closed 2 months ago
apparently this was added in 784e946af417955aa0c3515e3f4053bc1a274413 all the way in
to complement ModalityAcquisitionLabel
. And I guess that is why it is Custom
, although I agree now that name is somewhat slightly misleading from its behavior...
I think we could add AcquisitionLabel
or PlainAcquisitionLabel
which would be making decision solely based on the _acq-<label>
. Care to submit a PR adding it (just git grep CustomAcq
to see all spots to change)?
Happy to.
I didn't duplicate create_dummy_no_shim_settings_custom_label_bids_session
, because I thought it's a little over the top. Do you want me to though?
Is there anything I should add here? Throw it all away and start over? :)
Addresses by #768
Summary
Apparently heudiconv prefers to use the task entity when trying to match fmaps to funcs.
While this is initially unintuitive (the option is called
CustomAcquisitionLabel
after all) I found it's also problematic when there is more than one task. How would I match a single fmap to multiple functionals here?Wouldn't it be better to try a shared
acq
label first and then only fall back to thetask
entity?Platform details:
Choose one:
[x] Local environment (Debian, Python 3.11)
[ ] Container
Heudiconv version: 1.1.6