Open tsalo opened 2 months ago
Attention: Patch coverage is 90.90909%
with 2 lines
in your changes missing coverage. Please review.
Project coverage is 82.15%. Comparing base (
a0a3635
) to head (59bb2ec
).
Files | Patch % | Lines |
---|---|---|
heudiconv/heuristics/reproin.py | 90.90% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Rename s variable to curr_seqinfo for improved clarity.
yeah, but complicates review a little due to diff now including changes I can ignore or not and need to decide when looking...
Could you submit a separate PR with that typo fix and such a rename (so no functionality change) and then let's improve this one -- yet to grasp on all the changes, and as we do not have any nice testing for reproin heuristic, I wonder how we could add one :-/ I would really be shy to accept without some way to test. Locally I could do using smth like https://github.com/nipy/heudiconv/blob/master/utils/test-compare-two-versions.sh but could we do better?!
:+1: I've opened #779 with the variable name change.
Closes #769. This is working on DICOMs associated with https://openneuro.org/datasets/ds005250.
Changes proposed:
infotodict
.RenameMoved to #779.s
variable tocurr_seqinfo
for improved clarity.series_description
and is a phase scan. If it is, set "part" to "mag".