nipy / heudiconv

Flexible DICOM conversion into structured directory layouts
https://heudiconv.readthedocs.io
Other
237 stars 126 forks source link

[WIP] Recompress files where dcm2niix failed #803

Open octomike opened 2 weeks ago

octomike commented 2 weeks ago

As threatened in #802 an alternative approach.

I decided to leverage the fact that heudiconv blindly moves all converted output files to nii.gz, even if they are just nii by renaming the successfully re-compressed image to .nii. This feels ugly, but results in the shortest/least-invasive PR.

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 28.00000% with 18 lines in your changes missing coverage. Please review.

Project coverage is 82.12%. Comparing base (900ccdc) to head (a72d5ec).

Files with missing lines Patch % Lines
heudiconv/convert.py 28.00% 18 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #803 +/- ## ========================================== - Coverage 82.48% 82.12% -0.36% ========================================== Files 42 42 Lines 4323 4348 +25 ========================================== + Hits 3566 3571 +5 - Misses 757 777 +20 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.