nipy / nibabel

Python package to access a cacophony of neuro-imaging file formats
http://nipy.org/nibabel/
Other
649 stars 258 forks source link

FIX: Catch random bad slice when testing image slicing #1221

Closed effigies closed 1 year ago

effigies commented 1 year ago

We have an apparent Heisenbug that would occasionally cause Windows tests to fail on Python 3.10.

After booting up a Windows machine and running ~30k tests with different PYTHONHASHSEEDs, it turns out it's a regular old bug based on a random selection that has nothing to do with Windows and Python 3.10. If the dimensionality of the sliced dataobj (can go up with Nones) exceeds 7, Analyze-like images can't represent it.

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (e221d77) 92.16% compared to head (8bb1b99) 92.16%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1221 +/- ## ======================================= Coverage 92.16% 92.16% ======================================= Files 98 98 Lines 12372 12372 Branches 2543 2543 ======================================= Hits 11403 11403 Misses 646 646 Partials 323 323 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nipy). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nipy)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.