search

nipy / nibabel

Python package to access a cacophony of neuro-imaging file formats
http://nipy.org/nibabel/
Other
649 stars 258 forks source link

MNT: Add py312-dev-x64 environment #1267

Closed effigies closed 11 months ago

effigies commented 11 months ago

cc @larsoner

larsoner commented 11 months ago

Also need to add an entry to https://github.com/nipy/nibabel/blob/e356408049ff9ecf42a843824e9b2728f7f0b80e/.github/workflows/test.yml#L113-L128, no?

I think a single run of NP2.0 is enough

larsoner commented 11 months ago

Happy to push CI changes here if you want

codecov[bot] commented 11 months ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (adcc9ba) 92.19% compared to head (98489b5) 92.22%. Report is 4 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1267 +/- ## ========================================== + Coverage 92.19% 92.22% +0.02% ========================================== Files 99 99 Lines 12458 12454 -4 Branches 2559 2559 ========================================== Hits 11486 11486 + Misses 648 644 -4 Partials 324 324 ``` [see 1 file with indirect coverage changes](https://app.codecov.io/gh/nipy/nibabel/pull/1267/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nipy)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

larsoner commented 11 months ago

Seems to be failing as intended!

https://github.com/nipy/nibabel/actions/runs/6562773154/job/17825525527?pr=1267#step:7:62

E   AttributeError: `np.sctypes` was removed in the NumPy 2.0 release. . Did you mean: 'dtypes'?
larsoner commented 11 months ago

@effigies feel free to merge and then we can see if https://github.com/nipy/nibabel/pull/1250 fixes things