search

nipy / nibabel

Python package to access a cacophony of neuro-imaging file formats
http://nipy.org/nibabel/
Other
649 stars 258 forks source link

FIX: Tolerate missing git #1286

Closed effigies closed 9 months ago

effigies commented 9 months ago

Closes gh-1285.

The alternative would be to catch the exception in the test, but I can't think of a good reason for us to crash the interpreter over this.

Any objections?

codecov[bot] commented 9 months ago

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (f7b9bc4) 92.23% compared to head (46a765d) 92.23%.

Files Patch % Lines
nibabel/pkg_info.py 20.00% 3 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1286 +/- ## ======================================= Coverage 92.23% 92.23% ======================================= Files 99 99 Lines 12459 12461 +2 Branches 2561 2562 +1 ======================================= + Hits 11492 11494 +2 Misses 643 643 Partials 324 324 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

effigies commented 9 months ago

I'll consider this reviewed by @yurivict. Thanks!