Closed DimitriPapadopoulos closed 6 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
f7b9bc4
) 92.24% compared to head (1ec8488
) 92.24%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Apply some Repo-Review suggestions.
I went for the low-hanging fruits, other changes are more invasive and deserve a PR of their own, such as using a formatter like ruff of black.
Also update minimal Python version for blue. By the way, isn't blue able to understand
requires-python
?Fixed issues
warn_unreachable = true
to pass this check. There are occasionally false positives (often due to platform or Python version static checks), so it's okay to ignore this check. But try it first - it can catch real bugs too."ignore-without-code"
inenable_error_code = [...]
. This will force all skips in your project to include the error code, which makes them more readable, and avoids skipping something unintended."redundant-expr"
inenable_error_code = [...]
. This helps catch useless lines of code, like checking the same condition twice."truthy-bool"
inenable_error_code = []
. This catches mistakes in using a value as truthy if it cannot be falsey.Issues ignored
Left for later because it requires extensive fixes:
strict
in the mypy config. MyPy is best with strict or nearly strict configuration. If you are happy with the strictness of your settings already, ignore this check or setstrict = false
explicitly.