search

nipy / nibabel

Python package to access a cacophony of neuro-imaging file formats
http://nipy.org/nibabel/
Other
649 stars 258 forks source link

MNT: blue/isort/flake8 → ruff #1289

Closed DimitriPapadopoulos closed 5 months ago

DimitriPapadopoulos commented 9 months ago

Fixes https://github.com/nipy/nibabel/pull/1288#discussion_r1436219280.

codecov[bot] commented 9 months ago

Codecov Report

Attention: Patch coverage is 83.33333% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 92.25%. Comparing base (c445edd) to head (066431d).

Files Patch % Lines
nibabel/cmdline/diff.py 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1289 +/- ## ========================================== - Coverage 92.26% 92.25% -0.02% ========================================== Files 99 99 Lines 12472 12453 -19 Branches 2566 2555 -11 ========================================== - Hits 11507 11488 -19 Misses 642 642 Partials 323 323 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

DimitriPapadopoulos commented 9 months ago

Also need to update the tox environments:

Done.

@effigies It's now ready for reviewing.

DimitriPapadopoulos commented 7 months ago

Bumping ruff from 0.1.9 to 0.3.0 is unexpectedly intrusive - lots of change by ruff format.

effigies commented 6 months ago

Thanks again for doing this, @DimitriPapadopoulos! Made a bunch of small comments.

DimitriPapadopoulos commented 6 months ago

I think I have addressed all the issues - plus some minor new changes.

effigies commented 6 months ago

@DimitriPapadopoulos There are several unaddressed comments above. They're hidden by default.

DimitriPapadopoulos commented 6 months ago

I think I have addressed all of them. Note that I rebased to fix a merge conflict.

DimitriPapadopoulos commented 6 months ago

Or not :smile:

The quantity of changes pushes the GitHub web interface to its limits. I have a hard time navigating the comments.

Still one to address, almost there.