Closed larsoner closed 4 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 92.17%. Comparing base (
e4facc1
) to head (11cf547
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This looks painful. np.array(copy=False)
-equivalent behavior is being changed to np.array(copy=None)
in 2.0 with no deprecation period.
Also, the type checking for the updated types will only work if mypy and numpy 2.0-dev are installed into the same environment. I think we're going to need to see if we can drop our custom ArrayLike
protocol and use numpy's directly. I can't immediately see another way to work with types that differ between stable and dev versions.
😨
Okay I'll leave that to another PR then! Hopefully it ends up being less painful than it sounds
Might fix https://github.com/mne-tools/mne-python/actions/runs/8127208745/job/22227091689?pr=12478#step:17:365 :
This was in MNE-Python with a MGZ file, but I imagine many tests using scientific-python-nightly-wheels in nibabel will fail similarly without this. @effigies or others feel free to close this or push directly if other changes are needed if it's easier than commenting!