Closed penguinpee closed 3 months ago
Attention: Patch coverage is 42.85714%
with 4 lines
in your changes are missing coverage. Please review.
Project coverage is 92.23%. Comparing base (
e5cd0e8
) to head (9fa116b
).
Files | Patch % | Lines |
---|---|---|
nibabel/deprecator.py | 42.85% | 3 Missing and 1 partial :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This looks good. Would you mind building the docs with 3.13 and taking a screenshot of a deprecated function? onetime.setattr_on_read
should work.
Well, this was a painful ask seeing that the top level Makefile
still references setup.py
which has been removed more than a year ago. It even calls sutup.py build
. Ouch!
Anyway, I hope this is what you were asking for:
If not, let me know. I have the entire HTML docs build with Python 3.13 available now.
Sorry, I always use make -C doc html
, so I don't often notice problems in the top-level Makefile.
Thanks for going to the effort, that looks good to me.
Sorry, I always use
make -C doc html
, so I don't often notice problems in the top-level Makefile.
Well, I was just following the instructions. PR #1316 will make sure other users like me have a less painful experience.