nipy / nibabel

Python package to access a cacophony of neuro-imaging file formats
http://nipy.org/nibabel/
Other
634 stars 258 forks source link

Python 3.13: Account for dedented docstrings #1315

Closed penguinpee closed 3 months ago

penguinpee commented 3 months ago
codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 42.85714% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 92.23%. Comparing base (e5cd0e8) to head (9fa116b).

Files Patch % Lines
nibabel/deprecator.py 42.85% 3 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1315 +/- ## ========================================== - Coverage 92.26% 92.23% -0.03% ========================================== Files 99 99 Lines 12472 12479 +7 Branches 2566 2568 +2 ========================================== + Hits 11507 11510 +3 - Misses 642 645 +3 - Partials 323 324 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

effigies commented 3 months ago

This looks good. Would you mind building the docs with 3.13 and taking a screenshot of a deprecated function? onetime.setattr_on_read should work.

penguinpee commented 3 months ago

Well, this was a painful ask seeing that the top level Makefile still references setup.py which has been removed more than a year ago. It even calls sutup.py build. Ouch!

Anyway, I hope this is what you were asking for:

nibabel onetime setattr_on_read

If not, let me know. I have the entire HTML docs build with Python 3.13 available now.

effigies commented 3 months ago

Sorry, I always use make -C doc html, so I don't often notice problems in the top-level Makefile.

Thanks for going to the effort, that looks good to me.

penguinpee commented 3 months ago

Sorry, I always use make -C doc html, so I don't often notice problems in the top-level Makefile.

Well, I was just following the instructions. PR #1316 will make sure other users like me have a less painful experience.