search

nipy / nibabel

Python package to access a cacophony of neuro-imaging file formats
http://nipy.org/nibabel/
Other
649 stars 258 forks source link

RF: Fix for `abc` library `Traversable` class module #1333

Closed jhlegarreta closed 3 months ago

jhlegarreta commented 3 months ago

Fix for abc library Traversable class module: import from importlib.resources.abc.

Fixes:

/home/runner/work/nibabel/nibabel/nibabel/testing/__init__.py:30:
 DeprecationWarning: 'importlib.abc.Traversable' is deprecated and slated for removal in Python 3.14
      from importlib.abc import Traversable

raised for example at: https://github.com/nipy/nibabel/actions/runs/9637811213/job/26577586721#step:7:157

Documentation: https://docs.python.org/3/library/importlib.resources.abc.html#importlib.resources.abc.Traversable

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.20%. Comparing base (adedf7b) to head (7caef99).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1333 +/- ## ======================================= Coverage 92.20% 92.20% ======================================= Files 98 98 Lines 12398 12398 Branches 2556 2556 ======================================= Hits 11431 11431 Misses 644 644 Partials 323 323 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jhlegarreta commented 3 months ago

Sorry Chris, no idea how to solve the riddle here after inspecting the build logs.

jhlegarreta commented 3 months ago

Down to 27K warnings (https://github.com/nipy/nibabel/actions/runs/9692730430/job/26746686623#step:7:376) from 29K (https://github.com/nipy/nibabel/actions/runs/9637811213/job/26577586721#step:7:434) :worried: with these fixes.