nipy / nibabel

Python package to access a cacophony of neuro-imaging file formats
http://nipy.org/nibabel/
Other
653 stars 258 forks source link

Indian code store in Gifti file should be "LittleEndian" instead of "GIFTI_ENDIAN_LITTLE" #283

Closed duchesnay closed 9 years ago

duchesnay commented 9 years ago

The gifti dtd "www.nitrc.org/frs/download.php/115/gifti.dtd" mentions: Endian (BigEndian | LittleEndian) #REQUIRED

However the recoding thanks to "gifti_endian_codes" in nibabel/nibabel/gifti/util.py Leads to store "GIFTI_ENDIAN_LITTLE". This cause problem to freesurfer to read gifti file generated with nibabel.

Additionaly, is it possible to swith the default encoding of GiftiDataArray() from B64GZ to B64BIN. This way Freesurfer and other gifti readers will be able to read gifti files generated by nibabel.

matthew-brett commented 9 years ago

Thanks for the report.

Have you tried installing nibabel from the current code? We did fix a couple of bugs like this, but we haven't made a release since then.

The next release will be in a few days, I hope.

matthew-brett commented 9 years ago

Hi @duchesnay - I'm assuming the new release fixes this - does it? Can I close this one?

matthew-brett commented 9 years ago

I believe this one is fixed by https://github.com/nipy/nibabel/pull/233 - but feel free to re-open if I'm wrong.