search

nipy / nipy.github.io

Main website for the Neuroimaging in Python community
http://nipy.org
8 stars 10 forks source link

Small rewording of the introduction sentences on the front page. #34

Closed arokem closed 8 years ago

vsoch commented 8 years ago

Travis was still installed as an integration - I've removed it so we shouldn't see this error in the future.

vsoch commented 8 years ago

Here is a link to the artifact

I like the idea of a "community of practice," but I don't think its a well known enough term to make this the first line of the opening. When I first read it (without seeing the link) it just sounded like bad English. Perhaps link to the wikipedia page to make it explicit? (+1 @satra 's suggestion)

The last sentence also needs some work! It should say that we welcome contributions, and invite the visitor to view standards of conduct or ask for help. The current version:

  We welcome standards of conduct, or ask for help. We develop the following projects:
arokem commented 8 years ago

Thanks both for the comment about CoP. I added the link to Wikipedia.

And thanks for pointing out that the rest was also broken. I think I've found the cause of that. See recent commits and:

https://circle-artifacts.com/gh/nipy/nipy.github.com/79/artifacts/0/home/ubuntu/nipy.github.com/_site/index.html

On Sat, May 7, 2016 at 11:03 AM, Vanessa Sochat notifications@github.com wrote:

Here is a link to the artifact https://circle-artifacts.com/gh/nipy/nipy.github.com/76/artifacts/0/home/ubuntu/nipy.github.com/_site/index.html

I like the idea of a "community of practice," but I don't think its a well known enough term to make this the first line of the opening. When I first read it (without seeing the link) it just sounded like bad English. Perhaps link to the wikipedia page to make it explicit? (+1 @satra https://github.com/satra 's suggestion)

The last sentence also needs some work! It should say that we welcome contributions, and invite the visitor to view standards of conduct or ask for help. The current version:

We welcome standards of conduct, or ask for help. We develop the following projects:

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/nipy/nipy.github.com/pull/34#issuecomment-217656553

vsoch commented 8 years ago

One tiny detail and I think we should be good to merge. The link should ideally open a new tab, so the user doesn't lose the nipy.org page. You can add

  target="_blank"

to the tag (as the others have done). Overall, looks good!

arokem commented 8 years ago

Done. I've also linked to twitter. Sorry for piling up new changes :-)

On Sat, May 7, 2016 at 12:25 PM, Vanessa Sochat notifications@github.com wrote:

One tiny detail and I think we should be good to merge. The link should ideally open a new tab, so the user doesn't lose the nipy.org page. You can add

target="_blank"

to the tag (as the others have done). Overall, looks good!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/nipy/nipy.github.com/pull/34#issuecomment-217663124, or mute the thread https://github.com/notifications/unsubscribe/AAHPNmzgzrCnpUKlhNO583z4fKmCxZBNks5p_Oc6gaJpZM4IZdN8 .

vsoch commented 8 years ago

No worries! Github doesn't seem to mind the multi-layered comment sandwich :)

vsoch commented 8 years ago

@arokem see https://github.com/arokem/nipy.github.com/pull/1 where I've put suggested changes.

arokem commented 8 years ago

I rebased this to squash it all into 3 neat commits.

vsoch commented 8 years ago

Looks good! Merging.