search

nipy / nipy.github.io

Main website for the Neuroimaging in Python community
http://nipy.org
8 stars 10 forks source link

[WIP] testing updated site build #52

Closed vsoch closed 5 years ago

vsoch commented 5 years ago

This will take a few tries to get right, just ignore until I say otherwise. The original build used a machine base and here I'm trying docker.

vsoch commented 5 years ago

Boum! And there you go. Merging!

bcipolli commented 5 years ago

lol when did we decide to drop the whole "community" aspect of "open source community". Do we not do code reviews here?

vsoch commented 5 years ago

It was just updating circleci to build with version 2.0, and it worked. I'm happy to revert if you think we need to spend time to discuss this. I figured that there was largely nothing to talk about, and was being considerate of others time. Please revert and start a discussion if you think necessary.

bcipolli commented 5 years ago

no need to revert. I'm a process kinda guy, and believe in review in everything. Feel free to ping me on any review.

Appreciate the work as always! Just wanted to say hi and offer my service :) Nothing more.

vsoch commented 5 years ago

Ah ok! You know, I thought about it, and now regret that I didn't ping you :) You have my promise that I will next time!

bcipolli commented 5 years ago

Always a pleasure to work together, and always an opportunity to learn (and probably, more commonly, request pointers to documentation :P )