search

nipy / nipype

Workflows and interfaces for neuroimaging packages
https://nipype.readthedocs.org/en/latest/
Other
751 stars 530 forks source link

[FIX] Deduplicate dcm2niix output #3610

Closed mauriliogenovese closed 8 months ago

mauriliogenovese commented 1 year ago

fixes #3579

codecov[bot] commented 1 year ago

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 63.18%. Comparing base (682abac) to head (39b3a2c). Report is 70 commits behind head on master.

:exclamation: Current head 39b3a2c differs from pull request most recent head 45e8076. Consider uploading reports for the commit 45e8076 to get more accurate results

Files Patch % Lines
nipype/interfaces/dcm2nii.py 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3610 +/- ## ========================================== - Coverage 63.18% 63.18% -0.01% ========================================== Files 308 308 Lines 40809 40810 +1 Branches 5652 5652 ========================================== Hits 25784 25784 - Misses 14013 14014 +1 Partials 1012 1012 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

effigies commented 8 months ago

Apologies for the delay. Is it possible to write a test that reproduces the issue?

mauriliogenovese commented 8 months ago

I cannot write a test without providing images from a subject and I don't have a public dataset. Anyway the pull request simply removes any duplicate entry from the final file list, so it would be fine in this and any other similar case.