search

nipy / nipype

Workflows and interfaces for neuroimaging packages
https://nipype.readthedocs.org/en/latest/
Other
751 stars 530 forks source link

FIX: Address numpy and traits deprecations #3699

Closed effigies closed 1 week ago

effigies commented 1 week ago

To unlock projects that want to support numpy 2, we need to disable our pin and fix some bugs that were probably generated in the 2to3 transition, namely using np.savetxt(..., fmt=b'...').

Started to test on Python 3.13, but we're blocked on a release of traits. Ran with latest master and addressed deprecations.

@mgxd Would you be up for a quick review?

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 90.00000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 72.86%. Comparing base (1ccee34) to head (ddb73ac). Report is 15 commits behind head on master.

Files with missing lines Patch % Lines
nipype/algorithms/rapidart.py 25.00% 3 Missing :warning:
nipype/algorithms/confounds.py 50.00% 1 Missing :warning:
nipype/interfaces/fsl/epi.py 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3699 +/- ## ========================================== + Coverage 70.81% 72.86% +2.04% ========================================== Files 1277 1278 +1 Lines 59153 59305 +152 Branches 8590 0 -8590 ========================================== + Hits 41890 43212 +1322 + Misses 16119 16093 -26 + Partials 1144 0 -1144 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚨 Try these New Features:

effigies commented 1 week ago

Okay, moving to tox because this CI is a pain to work with.