search

nipy / nitransforms

a standalone fork of nipy/nibabel#656
https://nitransforms.readthedocs.io
MIT License
28 stars 17 forks source link

ENH: Base implementation of B-Spline transforms #138

Closed oesteban closed 2 years ago

oesteban commented 2 years ago

Addressing #106.

pep8speaks commented 2 years ago

Hello @oesteban! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2022-02-24 11:04:52 UTC
oesteban commented 2 years ago

I think this base chunk of code can be reviewed. Please note I'm aware of #154.

codecov-commenter commented 2 years ago

Codecov Report

Merging #138 (f232acf) into master (f703445) will increase coverage by 0.06%. The diff coverage is 98.83%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #138      +/-   ##
==========================================
+ Coverage   97.82%   97.88%   +0.06%     
==========================================
  Files          12       13       +1     
  Lines        1104     1184      +80     
  Branches      171      183      +12     
==========================================
+ Hits         1080     1159      +79     
  Misses         18       18              
- Partials        6        7       +1
Flag Coverage Δ
travis 97.80% <98.83%> (+0.15%) :arrow_up:
unittests 97.81% <98.83%> (+0.07%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
nitransforms/nonlinear.py 98.76% <98.30%> (-1.24%) :arrow_down:
nitransforms/base.py 100.00% <100.00%> (ø)
nitransforms/interp/bspline.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f703445...f232acf. Read the comment docs.