search

nipy / nitransforms

a standalone fork of nipy/nibabel#656
https://nitransforms.readthedocs.io
MIT License
28 stars 17 forks source link

ENH: Guess open linear transform formats #160

Closed oesteban closed 2 years ago

oesteban commented 2 years ago

EAFP implementation of loading linear transforms without specifying the format of the file.

Resolves: #86. Resolves: #87. Resolves: #107.

codecov-commenter commented 2 years ago

Codecov Report

Merging #160 (bb8bf32) into master (4d4e3d9) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #160   +/-   ##
=======================================
  Coverage   98.59%   98.59%           
=======================================
  Files          13       13           
  Lines        1208     1208           
  Branches      184      184           
=======================================
  Hits         1191     1191           
  Misses         10       10           
  Partials        7        7
Flag Coverage Δ
travis 96.77% <97.77%> (ø)
unittests 98.54% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
nitransforms/io/__init__.py 100.00% <100.00%> (ø)
nitransforms/io/afni.py 98.33% <100.00%> (+0.04%) :arrow_up:
nitransforms/io/base.py 100.00% <100.00%> (ø)
nitransforms/io/fsl.py 91.74% <100.00%> (ø)
nitransforms/io/itk.py 100.00% <100.00%> (ø)
nitransforms/linear.py 96.82% <100.00%> (-0.28%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3b1f125...bb8bf32. Read the comment docs.

pep8speaks commented 2 years ago

Hello @oesteban! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2022-03-02 08:27:32 UTC
oesteban commented 2 years ago

Hey @effigies, just FYI, I requested your review. It'd be nice to have your feedback esp. regarding error types. Since the interim report is out, this is not urgent anymore - so whenever you feel you have the availability/energy.

This does not introduce any major changes to the code, so an alternative route is to postpone deep review for #110.

oesteban commented 2 years ago

@effigies do you want to bump this?

Also a good warming up for @mgxd, now he's returning :)

effigies commented 2 years ago

Sorry, yes, I'll try to get back to this this week.

oesteban commented 2 years ago

Bumping up

oesteban commented 2 years ago

Any chance to get more eyes on this? @mgxd @effigies