nipy / nitransforms

a standalone fork of nipy/nibabel#656
https://nitransforms.readthedocs.io
MIT License
28 stars 15 forks source link

MAINT: Loosen dependencies #164

Closed mgxd closed 1 year ago

codecov[bot] commented 2 years ago

Codecov Report

Patch coverage has no change and project coverage change: -0.05 :warning:

Comparison is base (951119e) 98.59% compared to head (46cdedc) 98.54%.

:exclamation: Current head 46cdedc differs from pull request most recent head 03b25e4. Consider uploading reports for the commit 03b25e4 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #164 +/- ## ========================================== - Coverage 98.59% 98.54% -0.05% ========================================== Files 13 13 Lines 1279 1169 -110 Branches 184 184 ========================================== - Hits 1261 1152 -109 Misses 10 10 + Partials 8 7 -1 ``` | Flag | Coverage Δ | | |---|---|---| | travis | `?` | | | unittests | `98.54% <ø> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nipy#carryforward-flags-in-the-pull-request-comment) to find out more. [see 9 files with indirect coverage changes](https://app.codecov.io/gh/nipy/nitransforms/pull/164/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nipy)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

oesteban commented 2 years ago

Hi @mgxd, sorry for my slow coming back to this. Could you remind me why this is necessary? It doesn't seem like a good idea to loosen up restrictions if the versions installed of numpy or scipy are not supported by the Python version.

effigies commented 1 year ago

Just looking at this... You really don't want a base library to have complicated install-time dependencies. Just declare a minimum version and move on. I suspect this was used when we were using python setup.py instead of pip, and the dependency resolution was terrible and did not respect python_requires.

oesteban commented 1 year ago

We probably want to update pins though, before going ahead, right?

mgxd commented 1 year ago

I think it should be fine, I'll rebase and trigger tests again

effigies commented 1 year ago

@oesteban Can you make me an admin on ReadTheDocs? I want to set up PR builds.

oesteban commented 1 year ago

@oesteban Can you make me an admin on ReadTheDocs? I want to set up PR builds.

done!

effigies commented 1 year ago

Sorry, Mathias. I forgot about dropping 3.7 in CI. Looks like we haven't been testing 3.10 or 3.11 either. Happy to take this over if you don't want to babysit the CI loops.

mgxd commented 1 year ago

Sure, I think this can be merged so you can just build off master

effigies commented 1 year ago

Sounds good.