nipy / nitransforms

a standalone fork of nipy/nibabel#656
https://nitransforms.readthedocs.io
MIT License
28 stars 15 forks source link

ENH: Collapse linear and nonlinear transforms chains #170

Open oesteban opened 1 year ago

oesteban commented 1 year ago

Very undertested, but there is a new test that uses a "collapsed" transform from an ITK's .h5 file with one affine and one nonlinear (and it works).

BSpline transforms are not currently supported.

Related: #167, #169. Resolves #89.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 66.66% and project coverage change: -0.17 :warning:

Comparison is base (54ad1ea) 98.59% compared to head (fbc9228) 98.42%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #170 +/- ## ========================================== - Coverage 98.59% 98.42% -0.17% ========================================== Files 13 13 Lines 1279 1273 -6 Branches 184 183 -1 ========================================== - Hits 1261 1253 -8 - Misses 10 11 +1 - Partials 8 9 +1 ``` | Flag | Coverage Δ | | |---|---|---| | travis | `96.77% <66.66%> (-0.18%)` | :arrow_down: | | unittests | `98.37% <66.66%> (-0.17%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nipy#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://app.codecov.io/gh/nipy/nitransforms/pull/170?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nipy) | Coverage Δ | | |---|---|---| | [nitransforms/linear.py](https://app.codecov.io/gh/nipy/nitransforms/pull/170?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nipy#diff-bml0cmFuc2Zvcm1zL2xpbmVhci5weQ==) | `95.55% <33.33%> (-1.57%)` | :arrow_down: | | [nitransforms/manip.py](https://app.codecov.io/gh/nipy/nitransforms/pull/170?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nipy#diff-bml0cmFuc2Zvcm1zL21hbmlwLnB5) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

oesteban commented 1 year ago

I will be resuscitating this one over this week. Thanks for your patience!

oesteban commented 2 months ago

@mattcieslak also this (I'm remembering as I go) :D