added SHAP output in gen_report, changed noshap to gen_shap, explained output structure in README

nipype / pydra-ml

Apache License 2.0

4 stars 10 forks source link

added SHAP output in gen_report, changed noshap to gen_shap, explained output structure in README #15

Closed danielmlow closed 4 years ago

danielmlow commented 4 years ago

added SHAP csv and figure output to gen_report with optional plotting and optional subdividing SHAP values per confusion matrix quadrants (TP, TN, FP, FN) or just plotting for all predictions
added SHAP specifications in short and long json samples
changed noshap to gen_shap and resulting logic
explained results-{timestep}.pkl structure and new SHAP dir in README

satra commented 4 years ago

left some comments. i don't want to introduce control over plotting. it should always happen.

you need to merge master to this. (please always make sure you are up to date with master when sending a pull-request.

danielmlow commented 4 years ago

I finished updating this PR a couple of hours ago. Some checks were not successful but don't know exactly why. Let me know if I should try to solve them

satra commented 4 years ago

@danielmlow - you didn't update the test.

satra commented 4 years ago

thanks @danielmlow - i'm merging this, but it seems like we could turn the report generation functions also into tasks and use a pydra workflow to run that as well.

danielmlow commented 4 years ago

ctions also into tasks and use a pydra workflow to run that as well.

I´ll add it as an issue. Perhaps there are some other things we may want to tackle first