nipype / pydra

Pydra Dataflow Engine
https://nipype.github.io/pydra/
Other
119 stars 57 forks source link

MNT: Add git-archive support for setuptools_scm #609

Closed effigies closed 1 year ago

effigies commented 1 year ago

Types of changes

Summary

Versioneer permitted git archive to store some limited version information in the artifacts, such as those generated by GitHub. setuptools_scm needs special prodding to do this.

This adds and tests the feature. In the process, I've split the build and test stages from the main tests so that we can test different installation methods.

Checklist

codecov[bot] commented 1 year ago

Codecov Report

Base: 76.86% // Head: 80.43% // Increases project coverage by +3.56% :tada:

Coverage data is based on head (d89106b) compared to base (e27886d). Patch coverage: 90.90% of modified lines in pull request are covered.

:exclamation: Current head d89106b differs from pull request most recent head 890f5de. Consider uploading reports for the commit 890f5de to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #609 +/- ## ========================================== + Coverage 76.86% 80.43% +3.56% ========================================== Files 19 20 +1 Lines 4362 4391 +29 Branches 1260 0 -1260 ========================================== + Hits 3353 3532 +179 - Misses 821 859 +38 + Partials 188 0 -188 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `80.43% <90.90%> (+3.66%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/nipype/pydra/pull/609?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [pydra/conftest.py](https://codecov.io/gh/nipype/pydra/pull/609/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-cHlkcmEvY29uZnRlc3QucHk=) | `72.22% <90.90%> (+25.79%)` | :arrow_up: | | [pydra/engine/workers.py](https://codecov.io/gh/nipype/pydra/pull/609/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-cHlkcmEvZW5naW5lL3dvcmtlcnMucHk=) | `18.76% <0.00%> (ø)` | | | [pydra/\_\_init\_\_.py](https://codecov.io/gh/nipype/pydra/pull/609/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-cHlkcmEvX19pbml0X18ucHk=) | `90.47% <0.00%> (ø)` | | | [pydra/engine/task.py](https://codecov.io/gh/nipype/pydra/pull/609/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-cHlkcmEvZW5naW5lL3Rhc2sucHk=) | `87.69% <0.00%> (+0.92%)` | :arrow_up: | | [pydra/utils/messenger.py](https://codecov.io/gh/nipype/pydra/pull/609/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-cHlkcmEvdXRpbHMvbWVzc2VuZ2VyLnB5) | `95.89% <0.00%> (+1.36%)` | :arrow_up: | | [pydra/engine/graph.py](https://codecov.io/gh/nipype/pydra/pull/609/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-cHlkcmEvZW5naW5lL2dyYXBoLnB5) | `94.68% <0.00%> (+1.99%)` | :arrow_up: | | [pydra/utils/profiler.py](https://codecov.io/gh/nipype/pydra/pull/609/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-cHlkcmEvdXRpbHMvcHJvZmlsZXIucHk=) | `45.80% <0.00%> (+2.29%)` | :arrow_up: | | [pydra/engine/submitter.py](https://codecov.io/gh/nipype/pydra/pull/609/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-cHlkcmEvZW5naW5lL3N1Ym1pdHRlci5weQ==) | `81.01% <0.00%> (+3.16%)` | :arrow_up: | | [pydra/engine/core.py](https://codecov.io/gh/nipype/pydra/pull/609/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-cHlkcmEvZW5naW5lL2NvcmUucHk=) | `92.96% <0.00%> (+3.66%)` | :arrow_up: | | [pydra/engine/state.py](https://codecov.io/gh/nipype/pydra/pull/609/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-cHlkcmEvZW5naW5lL3N0YXRlLnB5) | `96.39% <0.00%> (+3.80%)` | :arrow_up: | | ... and [6 more](https://codecov.io/gh/nipype/pydra/pull/609/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

effigies commented 1 year ago

Getting bitten by https://github.com/pytest-dev/pytest/issues/1596. Fortunately we're not trying to use the --dask option anywhere in CI, so just wrapping it up in a try/except.