Closed ghisvail closed 1 year ago
I took this opportunity to fix a few typos and warnings which PyCharm complained about.
Base: 81.23% // Head: 81.16% // Decreases project coverage by -0.06%
:warning:
Coverage data is based on head (
549c018
) compared to base (a9a116d
). Patch coverage: 100.00% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
LGTM.
Is it ok if I merge this?
yes, sorry, thank you! I will create a new release during the weekend
See #613 for context. I looked at the code path @effigies suggested where the fix should be implemented.
This PR should facilitate composition of interfaces producing and consuming iterable types, not just lists. Sets and tuples provide additional guarantees which are quite nice, such as uniqueness and size boundness respectively. Since strings and bytes also satisfy the
Iterable
protocol in Python, these need to be discarded explicitly in the instance type check.Closes #613