search

nipype / pydra

Pydra Dataflow Engine
https://nipype.github.io/pydra/
Other
120 stars 59 forks source link

Add tests for `--error` and `--output` as `sbatch_args` in `test_submitter` #638

Open adi611 opened 1 year ago

adi611 commented 1 year ago

Types of changes

Summary

Added tests for valid --error and --output as sbatch_args.

Checklist

I am getting error for test_slurm_args_3 while testing (which checks for --error) - AttributeError: 'NoneType' object has no attribute 'replace' image Possible reason for this could be in workers.py here. In this, we are assigning error_file to None when --error flag is indeed detected. And later we are using .replace() function on error_file which is None in our case.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: +43.44 :tada:

Comparison is base (5ada4ca) 38.27% compared to head (7bc7013) 81.72%.

:exclamation: Current head 7bc7013 differs from pull request most recent head 0acb8a7. Consider uploading reports for the commit 0acb8a7 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #638 +/- ## =========================================== + Coverage 38.27% 81.72% +43.44% =========================================== Files 20 20 Lines 4394 4394 Branches 1202 0 -1202 =========================================== + Hits 1682 3591 +1909 + Misses 2417 803 -1614 + Partials 295 0 -295 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `81.72% <ø> (+43.46%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#carryforward-flags-in-the-pull-request-comment) to find out more. [see 18 files with indirect coverage changes](https://codecov.io/gh/nipype/pydra/pull/638/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.