nipype / pydra

Pydra Dataflow Engine
https://nipype.github.io/pydra/
Other
119 stars 57 forks source link

Typing bugfixes #687

Closed tclose closed 10 months ago

tclose commented 10 months ago

Types of changes

Summary

Checklist

codecov[bot] commented 10 months ago

Codecov Report

Patch coverage: 96.00% and project coverage change: -0.35% :warning:

Comparison is base (91c5a15) 83.23% compared to head (07ce62a) 82.88%. Report is 2 commits behind head on master.

:exclamation: Current head 07ce62a differs from pull request most recent head 103cefc. Consider uploading reports for the commit 103cefc to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #687 +/- ## ========================================== - Coverage 83.23% 82.88% -0.35% ========================================== Files 22 22 Lines 4848 4873 +25 Branches 1392 0 -1392 ========================================== + Hits 4035 4039 +4 - Misses 809 834 +25 + Partials 4 0 -4 ``` | [Flag](https://app.codecov.io/gh/nipype/pydra/pull/687/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nipype) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/nipype/pydra/pull/687/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nipype) | `82.88% <96.00%> (-0.35%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nipype#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files Changed](https://app.codecov.io/gh/nipype/pydra/pull/687?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nipype) | Coverage Δ | | |---|---|---| | [pydra/utils/typing.py](https://app.codecov.io/gh/nipype/pydra/pull/687?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nipype#diff-cHlkcmEvdXRpbHMvdHlwaW5nLnB5) | `93.24% <90.00%> (+0.26%)` | :arrow_up: | | [pydra/engine/helpers.py](https://app.codecov.io/gh/nipype/pydra/pull/687?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nipype#diff-cHlkcmEvZW5naW5lL2hlbHBlcnMucHk=) | `86.66% <100.00%> (+0.07%)` | :arrow_up: | | [pydra/engine/helpers\_file.py](https://app.codecov.io/gh/nipype/pydra/pull/687?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nipype#diff-cHlkcmEvZW5naW5lL2hlbHBlcnNfZmlsZS5weQ==) | `92.59% <100.00%> (+0.24%)` | :arrow_up: | | [pydra/engine/specs.py](https://app.codecov.io/gh/nipype/pydra/pull/687?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nipype#diff-cHlkcmEvZW5naW5lL3NwZWNzLnB5) | `94.75% <100.00%> (+0.03%)` | :arrow_up: | ... and [4 files with indirect coverage changes](https://app.codecov.io/gh/nipype/pydra/pull/687/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nipype)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

tclose commented 10 months ago

@djarecka I believe this is ready to merge now. The new SLURM test seems to be getting stuck somewhere

effigies commented 10 months ago

Merging so #684 can be rebased on master and reviewed more easily.