nipype / pydra

Pydra Dataflow Engine
https://nipype.github.io/pydra/
Other
119 stars 57 forks source link

Omit false output templates #693

Closed tclose closed 10 months ago

tclose commented 10 months ago

Types of changes

Summary

Optional output fields with output_file_template metadata (i.e. of type=ty.Union[Path, bool]) were getting printed to the command line regardless of whether a value for the field was set to False.

Checklist

codecov[bot] commented 10 months ago

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.50% :warning:

Comparison is base (91c5a15) 83.23% compared to head (4d10b57) 82.73%.

:exclamation: Current head 4d10b57 differs from pull request most recent head 62e3944. Consider uploading reports for the commit 62e3944 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #693 +/- ## ========================================== - Coverage 83.23% 82.73% -0.50% ========================================== Files 22 22 Lines 4848 4849 +1 Branches 1392 0 -1392 ========================================== - Hits 4035 4012 -23 - Misses 809 837 +28 + Partials 4 0 -4 ``` | [Flag](https://app.codecov.io/gh/nipype/pydra/pull/693/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nipype) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/nipype/pydra/pull/693/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nipype) | `82.73% <100.00%> (-0.50%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nipype#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files Changed](https://app.codecov.io/gh/nipype/pydra/pull/693?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nipype) | Coverage Δ | | |---|---|---| | [pydra/engine/helpers\_file.py](https://app.codecov.io/gh/nipype/pydra/pull/693?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nipype#diff-cHlkcmEvZW5naW5lL2hlbHBlcnNfZmlsZS5weQ==) | `91.80% <ø> (-0.55%)` | :arrow_down: | | [pydra/engine/helpers.py](https://app.codecov.io/gh/nipype/pydra/pull/693?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nipype#diff-cHlkcmEvZW5naW5lL2hlbHBlcnMucHk=) | `86.35% <100.00%> (-0.25%)` | :arrow_down: | ... and [4 files with indirect coverage changes](https://app.codecov.io/gh/nipype/pydra/pull/693/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nipype)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.