Closed tclose closed 6 months ago
Attention: Patch coverage is 97.05882%
with 2 lines
in your changes are missing coverage. Please review.
Project coverage is 83.93%. Comparing base (
0e66136
) to head (ff281aa
).
Files | Patch % | Lines |
---|---|---|
pydra/engine/submitter.py | 88.23% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I believe this is good for review now. The new SLURM test keeps on getting stuck somewhere but I assume that it isn't related
NB: I'm not sure why the coverage is down. It seems to be an issue with the dask submitter code
indeed looks like the coverage has dropped, what is weird, since for some time we didn't test Dask
at all...
indeed looks like the coverage has dropped, what is weird, since for some time we didn't test
Dask
at all...
I don't trust codecov in this instance (and others). The dask test is passing so it couldn't be missing the Dask submitter, which is where the bulk of the coverage drop comes from (otherwise it would be a coverage increase I believe)
@djarecka I believe this is ready to merge now
I'm good with merging, thank you @tclose !
Types of changes
Summary
Addresses #681 issue
Checklist