nipype / pydra

Pydra Dataflow Engine
https://nipype.github.io/pydra/
Other
120 stars 59 forks source link

implemented "with-timeout" plugin for testing the startup phase of lo… #732

Closed tclose closed 7 months ago

tclose commented 7 months ago

…ng-running shell-command tasks

Types of changes

Summary

This PR adds a new worker to be used solely for testing of interfaces (in particularly the auto-converted interfaces from nipype). Given it is to be used purely for test purposes, it isn't ideal to have to add it in globally into the WORKERS dict but there doesn't seem a way to "bring your own" worker. Perhaps this would be better

Checklist

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.36%. Comparing base (1720ba6) to head (4d59aca).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #732 +/- ## ========================================== + Coverage 83.35% 83.36% +0.01% ========================================== Files 24 24 Lines 4949 4964 +15 Branches 1411 1411 ========================================== + Hits 4125 4138 +13 - Misses 816 818 +2 Partials 8 8 ``` | [Flag](https://app.codecov.io/gh/nipype/pydra/pull/732/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nipype) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/nipype/pydra/pull/732/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nipype) | `83.36% <100.00%> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nipype#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

tclose commented 7 months ago

Closing in favour of BYO approach in #733