nipype / pydra

Pydra Dataflow Engine
https://nipype.github.io/pydra/
Other
119 stars 57 forks source link

Add note instead of catching and raising unhashable exception #734

Closed tclose closed 3 months ago

tclose commented 3 months ago

Types of changes

Summary

This is minor change to stop catching specific exceptions and re-raising generic UnhashbleExceptions, in favour of adding a note to the original exception to aid debugging in an editor. Currently, when debugging in an editor, the execution breaks at the UnhashableException rather than the underlying cause of the exception.

The only change in functionality is that of the type of exception raised

Checklist

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.28%. Comparing base (811dc45) to head (317392c). Report is 4 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #734 +/- ## ========================================== + Coverage 84.22% 84.28% +0.05% ========================================== Files 25 26 +1 Lines 5123 5128 +5 Branches 1449 1447 -2 ========================================== + Hits 4315 4322 +7 + Misses 802 800 -2 Partials 6 6 ``` | [Flag](https://app.codecov.io/gh/nipype/pydra/pull/734/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nipype) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/nipype/pydra/pull/734/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nipype) | `84.28% <100.00%> (+0.05%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nipype#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.