nipype / pydra

Pydra Dataflow Engine
https://nipype.github.io/pydra/
Other
120 stars 59 forks source link

Handle None types #742

Closed tclose closed 5 months ago

tclose commented 6 months ago

Types of changes

Summary

Checklist

added by @ghisvail Closes #744

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.71%. Comparing base (e52e32b) to head (a7ac191).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #742 +/- ## ========================================== + Coverage 84.27% 91.71% +7.43% ========================================== Files 26 55 +29 Lines 5127 15681 +10554 Branches 1447 2792 +1345 ========================================== + Hits 4321 14382 +10061 - Misses 800 1291 +491 - Partials 6 8 +2 ``` | [Flag](https://app.codecov.io/gh/nipype/pydra/pull/742/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nipype) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/nipype/pydra/pull/742/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nipype) | `91.71% <100.00%> (+7.43%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nipype#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ghisvail commented 6 months ago

I did a superficial read of the diff and what I checked so far looked sensible 👍